feat: update default changelog titles#1143
feat: update default changelog titles#1143paduszyk wants to merge 2 commits intocommitizen-tools:v5from
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1143 +/- ##
==========================================
+ Coverage 97.33% 97.57% +0.24%
==========================================
Files 42 55 +13
Lines 2104 2603 +499
==========================================
+ Hits 2048 2540 +492
- Misses 56 63 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Lee-W
added
pr-status: ready-to-merge
| ConventionalCommitsCz, | ||
| "change_type_map", | ||
| { | ||
| "feat": "Feat", |
There was a problem hiding this comment.
Why are the tests using the old format?
There was a problem hiding this comment.
I did not want to change the tests. So I applied mocking instead to hard-coding the new values.
IMHO: For tests, the names should not matter, I guess. The point is what the values are actually used for.
There was a problem hiding this comment.
It might be a bit confusing as these are no longer the actual default_change_type_map when someone's tracing the test cases, they might be misled
|
@paduszyk Hi, would it be possible for us to address #1119 (comment). I think we're really close to merging! |
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
pr-status: ready-to-merge
|
I would flag this change as breaking as it means any user having a custom |
Sounds good! Let me add the label |
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
I think we need to change the test cases
It's been a while... Sorry. @Lee-W Are you sure? This will result in a relatively large diff, taking into account the source itself will remain basically untouched except the update literals... |
|
I agree that test cases should be updated, otherwise it will cause confusion to future contributors. I don't think relatively large diff on test files is an issue. |
5 participants
Description
This updates the default titles of the changelog's sections in
ConventionalCommitsCz.Checklist
./scripts/formatand./scripts/testlocally to ensure this change passes linter check and testExpected behavior
Changelogs are more human-readable.
Additional context
Closes #1119.